Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gok: add gus command + subcommands #62

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gok: add gus command + subcommands #62

wants to merge 1 commit into from

Conversation

damdo
Copy link
Contributor

@damdo damdo commented Sep 10, 2023

This introduces the gok gus command along with implementation for its subcommands: diff, set, unset.

TODO:

  • add missing unset API on GUS/gokapi

@damdo damdo force-pushed the add-gus-subcommand branch 2 times, most recently from 032fcdf to b84ef5e Compare October 13, 2023 13:59
stapelberg
stapelberg requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@stapelberg stapelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I think you accidentally included a bunch of builddir/ directories in the PR, though?

internal/gok/set.go Outdated Show resolved Hide resolved
@damdo damdo force-pushed the add-gus-subcommand branch from b84ef5e to 864ca4c Compare October 22, 2023 08:58
@damdo
Copy link
Contributor Author

damdo commented Oct 22, 2023

Oops good catch, /builddir removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stapelberg stapelberg stapelberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damdo @stapelberg